Attribute defined outside
__init__ PYL-W0201
Anti-pattern
Minor
6 months ago
—
3 years old
Attribute '_current_reactor_provides' defined outside __init__
409 old_metadata = node.metadata._metastack.pop_layer(1, reactor_name)
410 self._in_a_reactor = True
411 self._current_reactor = (node.name, reactor_name)
412 self._current_reactor_provides = getattr(reactor, '_provides', (("/",),)) # used in .get()413 self._current_reactor_newly_requested_paths = set()
414 self._reactor_runs[self._current_reactor] += 1
415 try:Attribute '_current_reactor' defined outside __init__
408 # make sure the reactor doesn't react to its own output
409 old_metadata = node.metadata._metastack.pop_layer(1, reactor_name)
410 self._in_a_reactor = True
411 self._current_reactor = (node.name, reactor_name)412 self._current_reactor_provides = getattr(reactor, '_provides', (("/",),)) # used in .get()
413 self._current_reactor_newly_requested_paths = set()
414 self._reactor_runs[self._current_reactor] += 1Attribute 'raw' defined outside __init__
406 raise RemoteException(str(e)) from e
407
408 run_result = RunResult()
409 run_result.raw = result410 run_result.stdout = repr(result)
411 run_result.stderr = ""
412 return run_resultAttribute 'executor' defined outside __init__
113 io.debug(_("spinning up worker pool {pool}").format(pool=self.pool_id))
114 processed_results = []
115 exit_code = None
116 self.executor = ThreadPoolExecutor(max_workers=self.number_of_workers)117 try:
118 while (
119 (self.tasks_available() and not QUIT_EVENT.is_set()) or
Description
Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.