Appending to list immediately following its definition PY-W0070
Anti-pattern
Major
10 months ago
—
10 months old
Appending to list immediately following its definition
97 def shiftStack(self, offsetByte):
98 stackDispl = offsetByte // self.addrSize
99 reg_reset = set(range(self.stackFirst, self.stackLast + 1))
100 flows = []101 flows.append(([self.stackREG], [self.stackREG]))
102
103 for i in range(self.stackFirst, self.stackLast + 1):
Description
Instead of appending items to a list just after creation, it should be refactored to add those items into the list definition itself.
Bad practice
procArgs = []
procArgs.append('terraform-analyzer')
procArgs.append('terraform-docs')
Recommended
procArgs = ['terraform-analyzer', 'terraform-docs']