Unnecessary use of comprehension PYL-R1721
Performance
Major
10 months ago
—
10 months old
Unnecessary use of a comprehension, use list(self.instList) instead.
466
467 def copy(self):
468 gdgt = Gadget(self.arch)
469 gdgt.instList = [i for i in self.instList]470 gdgt.firstInst = self.firstInst
471 gdgt.gadgetMatrix = self.gadgetMatrix.copy()
472 gdgt.max_cost = self.max_costUnnecessary use of a comprehension, use list(range(sF, sL + 1)) instead.
124 stackTop = gdgtCollection.arch.stackTop
125 sL = gdgtCollection.arch.stackLast
126
127 STACK_codes = [i for i in range(sF, sL + 1)]128 STACK_strings = ["stack_" + str(i - stackTop) for i in range(sF, sL + 1)]
129
130 deref = gdgtCollection.arch.deref
Description
It is unnecessary to use a comprehension just to loop over the iterable and create a list/set/dict out of it.
Python has a specialized set of tools for this task: the list/set/dict constructors, which are faster and more readable.
Bad practice
states = [
('AL', 'Alabama'),
('AK', 'Alaska'),
('AZ', 'Arizona'),
('AR', 'Arkansas'),
('CA', 'California'),
# ...
]
abbreviations_to_names = {
abbreviation: name
for abbreviation, name in states
}
Recommended
states = [
('AL', 'Alabama'),
('AK', 'Alaska'),
('AZ', 'Arizona'),
('AR', 'Arkansas'),
('CA', 'California'),
# ...
]
abbreviations_to_names = dict(states)