Attribute defined outside
__init__ PYL-W0201
Anti-pattern
Minor
4 years ago
—
5 years old
Attribute '_cache_chain_cond_dep' defined outside __init__
404 chainCond_maxDep.add(i)
405 return chainCond_maxDep
406
407 self._cache_chain_cond_dep = UpdateChainCondDep(self)408 return self._cache_chain_cond_dep
409
410 def countChainCondDep(self):Attribute '_cache_countDep' defined outside __init__
385 return None
386
387 def countDep(self):
388 self._cache_countDep = self.gadgetMatrix.matrix.count_nonzero()389 return self._cache_countDep
390
391 def getChainCondDep(self):Attribute '_cache_deref_dep' defined outside __init__
429 deref_maxDep.discard(self.arch.deref)
430 return deref_maxDep
431
432 self._cache_deref_dep = UpdateDerefDep(self)433 return self._cache_deref_dep
434
435 def countDerefDep(self):Attribute '_cache_to_sets' defined outside __init__
323 if "_cache_to_sets" not in self.__dict__:
324 self._cache_to_sets = UpdateToSets(self)
325 elif self._cache_matrix_last_modification > time():
326 self._cache_to_sets = UpdateToSets(self)327
328 return self._cache_to_sets
329Attribute '_cache_to_sets' defined outside __init__
191 return accDiagFalse, accNDiagTrue
192
193 if "_cache_to_sets" not in self.__dict__:
194 self._cache_to_sets = UpdateToSets(self)195 elif self._cache_matrix_last_modification > time():
196 self._cache_to_sets = UpdateToSets(self)
197
Description
Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.