Nested
if can be replaced with else if CRT-A0011
Anti-pattern
Major
5 months ago
—
4 years old
can replace 'else {if cond {}}' with 'else if cond {}'
33func CheckKernelVersion(k, major, minor int) (bool, error) {
34 if v, err := GetKernelVersion(); err != nil {
35 return false, err
36 } else {37 if CompareKernelVersion(*v, VersionInfo{Kernel: k, Major: major, Minor: minor}) < 0 {
38 return false, nil
39 }can replace 'else {if cond {}}' with 'else if cond {}'
584 for name, inputSource := range resolved {
585 if inputSource.ResolveError != "" {
586 erroredValues[name] = string(inputSource.ResolveError)
587 } else {588 if ok {
589 var versionID int
590 err := setup.psql.Select("v.id").can replace 'else {if cond {}}' with 'else if cond {}'
1743 return nil, err
1744 }
1745 }
1746 } else {1747 if job.Serial || job.RawMaxInFlight > 0 {
1748 err = registerSerialGroup(tx, job.Name, jobID)
1749 if err != nil {can replace 'else {if cond {}}' with 'else if cond {}'
277 return err
278 }
279 }
280 } else {281 if jobConfig.Serial || jobConfig.RawMaxInFlight > 0 {
282 err = registerSerialGroup(tx, jobConfig.Name, jobNameToID[jobConfig.Name])
283 if err != nil {
Description
A single nested if inside an else block can be replaced with an else if.
It's better to have as little nesting as possible. Hence, it's cleaner to
replace a single nested if inside an else with an else-if.
Bad practice
if cond1 {
// do something
} else {
if x := cond2; x {
// do something else
}
}
Recommended
if cond1 {
// do something
} else if x := cond2; x {
// do something else
}