Function literal can be simplified CRT-A0018
Anti-pattern
Major
5 months ago
—
4 years old
replace
func() []Worker {
return fly.GetWorkers()
} with fly.GetWorkers 83 )
84
85 By("seeing that there are no workers")
86 Eventually(func() []Worker { 87 return fly.GetWorkers()
88 }, 1*time.Minute, 1*time.Second).
89 Should(HaveLen(0))
Description
Function literals that only call a single function, without making any other changes to the value of the inner function, can be removed, as they are redundant. Instead, the inner function, that is being called inside the outer function should be called.
Bad practice
_ = func(x int, y int) int { return add(x, y) }(1, 2)
Recommended
_ = add(1, 2)