The boolean expression can be simplified CRT-D0018
Bug risk
Major
4 months ago
—
3 years old
can simplify
bs.unusedBuilds && len(bs.builds)-bs.offset+1 > 0 to bs.unusedBuilds && len(bs.builds)-bs.offset >= 0733}
734
735func (bs *PaginatedBuilds) HasNext() bool {
736 return bs.unusedBuilds && len(bs.builds)-bs.offset+1 > 0737}
738
739func (bs *PaginatedBuilds) migrateLimit(ctx context.Context) (bool, error) {
Description
Some boolean expressions can be simplified to be more concise and readable.
Bad practice
var x, y int
if x > y - 1 {}
x < y || x == y
Recommended
var x, y int
if x >= y {}
x <= y