Function params involve heavy amount of copying CRT-P0003
Performance
Major
4 months ago
—
4 years old
cmd is heavy (1616 bytes); consider passing it by pointer
23 GenerateKey GenerateKeyCommand `command:"generate-key" description:"Generate RSA key for use with Concourse components."`
24}
25
26func (cmd ConcourseCommand) LessenRequirements(parser *flags.Parser) {27 cmd.Quickstart.LessenRequirements(parser.Find("quickstart"))
28 cmd.Web.LessenRequirements(parser.Find("web"))
29 cmd.Worker.LessenRequirements("", parser.Find("worker"))
Description
When a param big in size (more than 80 bytes) is passed to another function, it is better to pass a pointer to the value around, rather than the value itself.
Bad practice
func f(x [1024]int) {}
Recommended
func f(x *[1024]int) {}