DeepSource
Dashboard Resources Pricing Discover Directory Log in

Run your first analysis.

Find thousands of code security and quality issues in your codebase, before they end up in production.

Start now

concourse / concourse

Use %q to quote a string in fmt.Sprintf format specifiers GO-R4002
Anti-pattern
Minor
5 months ago — a year old
use %q instead of "%s" for quoted strings
worker/baggageclaim/uidgid/max_valid_uid.go
75}
76
77func (p ParseError) Error() string {
78	return fmt.Sprintf(`%s while parsing line "%s"`, p.Err, p.Line)79}
80
81func must(a int, err error) int {
use %q instead of "%s" for quoted strings
worker/baggageclaim/client_test.go
 37		})
 38
 39		mockErrorResponse := func(method string, endpoint string, message string, status int) {
 40			response := fmt.Sprintf(`{"error":"%s"}`, message) 41			bcServer.AppendHandlers(
 42				ghttp.CombineHandlers(
 43					ghttp.VerifyRequest(method, endpoint),
use %q instead of "%s" for quoted strings
testflight/pin_resource_test.go
28			Expect(watch).To(gbytes.Say("succeeded"))
29
30			watch = fly("pin-resource", "-r", inPipeline("some-resource"), "-v", fmt.Sprintf(`version:%s`, someResourceV1), "-c", "some comment")
31			Expect(watch).To(gbytes.Say(fmt.Sprintf("pinned '%s' with version {\"version\":\"%s\"}\n", inPipeline("some-resource"), someResourceV1)))32			Expect(watch).To(gbytes.Say("pin comment 'some comment' is saved"))
33
34			watch = fly("trigger-job", "-j", inPipeline("some-passing-job"), "-w")
use %q instead of "%s" for quoted strings
fly/commands/curl.go
78func printableCommand(args []string) string {
79	for i, arg := range args {
80		if strings.Contains(arg, " ") {
81			args[i] = fmt.Sprintf(`"%s"`, arg)82		}
83	}
84
use %q instead of "%s" for quoted strings
fly/commands/completion.go
51		}
52
53		if short != "" {
54			template += fmt.Sprintf(" -s \"%s\"", short)55		}
56
57		snippet += template + "\n"