DeepSource
Dashboard Resources Pricing Discover Directory Log in

Run your first analysis.

Find thousands of code security and quality issues in your codebase, before they end up in production.

Start now

concourse / concourse

Unnecessary dereference expressions GO-R4004
Anti-pattern
Major
5 months ago — a year old
could simplify (*base).TLSClientConfig to base.TLSClientConfig
fly/rc/target_test.go
250
251				expectedX509Cert, err := tls.X509KeyPair([]byte(clientCert), []byte(clientKey))
252
253				Expect((*base).TLSClientConfig).To(Equal(&tls.Config{254					InsecureSkipVerify: false,
255					Certificates:       []tls.Certificate{expectedX509Cert},
256				}))
could simplify (*transport).Base to transport.Base
fly/rc/target_test.go
245				Expect(err).NotTo(HaveOccurred())
246				transport, ok := target.Client().HTTPClient().Transport.(*oauth2.Transport)
247				Expect(ok).To(BeTrue())
248				base, ok := (*transport).Base.(*http.Transport)249				Expect(ok).To(BeTrue())
250
251				expectedX509Cert, err := tls.X509KeyPair([]byte(clientCert), []byte(clientKey))
could simplify (*base).TLSClientConfig to base.TLSClientConfig
fly/rc/target_test.go
200				ok = expectedCaCertPool.AppendCertsFromPEM([]byte(rootCA))
201				Expect(ok).To(BeTrue())
202
203				config := (*base).TLSClientConfig204				Expect(config.InsecureSkipVerify).To(Equal(false))
205				// x509.CertPool lazyily loads certs, which breaks direct equality comparisions
206				Expect(config.RootCAs.Subjects()).To(Equal(expectedCaCertPool.Subjects()))
could simplify (*transport).Base to transport.Base
fly/rc/target_test.go
187				Expect(err).NotTo(HaveOccurred())
188				transport, ok := target.Client().HTTPClient().Transport.(*oauth2.Transport)
189				Expect(ok).To(BeTrue())
190				base, ok := (*transport).Base.(*http.Transport)191				Expect(ok).To(BeTrue())
192
193				var expectedCaCertPool *x509.CertPool
could simplify (*base).TLSClientConfig to base.TLSClientConfig
fly/rc/target_test.go
153				})))
154				base, ok := (*transport).Base.(*http.Transport)
155				Expect(ok).To(BeTrue())
156				Expect((*base).TLSClientConfig).To(Equal(&tls.Config{157					InsecureSkipVerify: true,
158					RootCAs:            nil,
159					Certificates:       []tls.Certificate{},