Redundant statements can be removed RVV-A0010
Anti-pattern
Major
5 months ago
—
3 years old
Omit unnecessary return statement
148 err = cmd.Run()
149 s.NoError(err)
150
151 return 152}
153
154func (s *IntegrationSuite) AfterTest(suiteName, testName string) {Omit unnecessary break at the end of case clause
489 case "https":
490 case "http":
491 case "":
492 break493 default:
494 return warnings, fmt.Errorf("background_image scheme must be either http, https or relative")
495 }
Description
Redundant statements, like a break at the end of a case block, can be removed for improving the code's readability.
Bad practice
loop:
for {
switch a {
case 1:
a++
println("one")
break // unnecessary
case 2:
println("two")
break loop
default:
println("default")
}
}
Recommended
loop:
for {
switch a {
case 1:
a++
println("one")
case 2:
println("two")
break loop
default:
println("default")
}
}