Unused parameter in function RVV-B0012
Bug risk
Minor
4 months ago
—
3 years old
parameter 'logger' seems to be unused, consider removing or renaming it as _
253 return os.Hostname()
254}
255
256func (cmd *WorkerCommand) baggageclaimRunner(logger lager.Logger) (ifrit.Runner, error) {257 volumesDir := filepath.Join(cmd.WorkDir.Path(), "volumes")
258
259 err := os.MkdirAll(volumesDir, 0755)parameter 'args' seems to be unused, consider removing or renaming it as _
77 return <-ifrit.Invoke(sigmon.New(runner)).Wait()
78}
79
80func (cmd *WorkerCommand) Runner(args []string) (ifrit.Runner, error) { 81 if cmd.ResourceTypes == "" {
82 cmd.ResourceTypes = flag.Dir(concourseCmd.DiscoverAsset("resource-types"))
83 }parameter 'fname' seems to be unused, consider removing or renaming it as _
30 return maxValidUid, maxValidGid, nil
31}
32
33func maxValidFromFile(fname string) (uint32, error) { 34 f, err := os.Open(uidMap)
35 if err != nil {
36 return 0, fmt.Errorf("open %s: %w", uidMap, err)parameter 'signal' seems to be unused, consider removing or renaming it as _
79
80// Signal - Not Implemented
81//
82func (p *Process) Signal(signal garden.Signal) (err error) {83 err = ErrNotImplemented
84 return
85}parameter 'suiteName' seems to be unused, consider removing or renaming it as _
151 return
152}
153
154func (s *IntegrationSuite) AfterTest(suiteName, testName string) { 155 s.gardenBackend.Stop()
156 os.RemoveAll(s.rootfs)
157 s.cleanupIptables()
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}