Unused parameter in function RVV-B0012
Bug risk
13 days ago
—
2 years old
parameter 'handles' seems to be unused, consider removing or renaming it as _
487
488// BulkMetrics - Not Implemented
489//
490func (b *GardenBackend) BulkMetrics(handles []string) (metrics map[string]garden.ContainerMetricsEntry, err error) {491 err = ErrNotImplemented
492 return
493}parameter 'handles' seems to be unused, consider removing or renaming it as _
480
481// BulkInfo - Not Implemented
482//
483func (b *GardenBackend) BulkInfo(handles []string) (info map[string]garden.ContainerInfoEntry, err error) {484 err = ErrNotImplemented
485 return
486}parameter 'logger' seems to be unused, consider removing or renaming it as _
56 return err
57}
58
59func (f *resourceCacheLifecycle) CleanInvalidWorkerResourceCaches(logger lager.Logger, batchSize int) error { 60 _, err := sq.Delete("worker_resource_caches").
61 Where(sq.Expr("id in (SELECT id FROM invalid_caches)")).
62 Prefix(parameter 'repository' seems to be unused, consider removing or renaming it as _
477 }
478}
479
480func (step *TaskStep) registerCaches(ctx context.Context, repository *build.Repository, config atc.TaskConfig, volumeMounts []runtime.VolumeMount, metadata db.ContainerMetadata) error {481 logger := lagerctx.FromContext(ctx)
482 for _, cacheConfig := range config.Caches {
483 for _, volumeMount := range volumeMounts {parameter 'logger' seems to be unused, consider removing or renaming it as _
377 return imageSpec, nil
378}
379
380func (step *TaskStep) containerInputs(logger lager.Logger, repository *build.Repository, config atc.TaskConfig, metadata db.ContainerMetadata) ([]runtime.Input, error) {381 var inputs []runtime.Input
382
383 var missingRequiredInputs []string
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}