Unused method receiver RVV-B0013
Bug risk
9 days ago
—
2 years old
Method receiver 'cmd' is not referenced in method's body, consider removing it
155 return nil
156}
157
158func (cmd *WorkerCommand) dnsProxyRunner(logger lager.Logger) (ifrit.Runner, error) {159 server, err := network.DNSServer()
160 if err != nil {
161 return nil, errMethod receiver 'cmd' is not referenced in method's body, consider removing it
219 return types, nil
220}
221
222func (cmd *WorkerCommand) hasFlags(prefix string) bool {223 env := os.Environ()
224
225 for _, envVar := range env {Method receiver 'cmd' is not referenced in method's body, consider removing it
68const guardianRuntime = "guardian"
69const houdiniRuntime = "houdini"
70
71func (cmd WorkerCommand) LessenRequirements(prefix string, command *flags.Command) { 72 // configured as work-dir/volumes
73 command.FindOptionByLongName(prefix + "baggageclaim-volumes").Required = false
74}Method receiver 'cmd' is not referenced in method's body, consider removing it
142
143var ErrNotRoot = errors.New("worker must be run as root")
144
145func (cmd *WorkerCommand) checkRoot() error {146 currentUser, err := user.Current()
147 if err != nil {
148 return errMethod receiver 's' is not referenced in method's body, consider removing it
89 }
90}
91
92func (s *SpecSuite) TestIDMappings() { 93 // TODO
94 //
95 // ensure that we mutate the right thing
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}