Found non-idiomatic returning of boolean expression SCC-S1008
Anti-pattern
Major
5 months ago
—
4 years old
should use 'return len(gdnSpec.NetOut) == 0' instead of 'if len(gdnSpec.NetOut) != 0 { return false }; return true'
296}
297
298func (b *GardenBackend) isHermetic(gdnSpec garden.ContainerSpec) bool {
299 if len(gdnSpec.NetOut) != 0 {300 return false
301 }
302
Description
Instead of conditionally checking for the value of a boolean expression and then
returning true or false, returning the expression itself simplifies the code
and improves readability.
Bad practice
if max > min {
return true
}
return false
Recommended
return max > min