Omit redundant
nil check around loop SCC-S1031
Anti-pattern
Major
5 months ago
—
4 years old
unnecessary nil check around range
113}
114
115func merge(base, extra url.Values) url.Values {
116 if extra != nil {117 for key, values := range extra {
118 for _, value := range values {
119 base.Add(key, value)
Description
When using range on nil slices and maps, the loop will never execute,
as the length of the iterable will be regarded as zero. This makes an additional
nil check around the loop unnecessary.
Bad practice
if s != nil {
for _, x := range s {
// ...
}
}
Recommended
for _, x := range s {
// ...
}