A function argument is overwritten before its first use SCC-SA4009
Bug risk
Major
4 months ago
—
4 years old
argument builds is overwritten before first use
170 return builds, err
171}
172
173func (command *BuildsCommand) validatePipelineBuilds(builds []atc.Build, currentTeam concourse.Team, page concourse.Page) ([]atc.Build, error) {174 _, err := command.Pipeline.Validate()
175 if err != nil {
176 return nil, errargument builds is overwritten before first use
150 return teams
151}
152
153func (command *BuildsCommand) validateJobBuilds(builds []atc.Build, currentTeam concourse.Team, page concourse.Page) ([]atc.Build, error) {154 var (
155 err error
156 found bool
Description
The function argument is overwritten before the passed value is read.
Bad practice
func (arg string) {
arg = "foo bar"
}
Recommended
func (arg string) {
use(arg)
arg = "foo bar"
}