Detected usage of
defer in for/range loop SCC-SA9001
Bug risk
Major
4 months ago
—
4 years old
defers in this range loop won't run unless the channel gets closed
299 continue
300 }
301
302 defer listener.Close()303
304 _, port, err := net.SplitHostPort(listener.Addr().String())
305 if err != nil {
Description
Using defer in for or range loop may not run when you expect them to. It is better to handle it explicitly than deferring it.
References
- https://stackoverflow.com/questions/37073538/why-defer-in-range-loop-is-called-in-a-reverse-order
- https://groups.google.com/forum/#!topic/golang-nuts/9SG7Do8pC6Q