parameter 'log' seems to be unused, consider removing or renaming it as _
54 return json.Marshal(&response)
55}
56
57func (manager *CredHubManager) Init(log lager.Logger) error { 58 var options []credhub.Option
59 if manager.TLS.Insecure {
60 options = append(options, credhub.SkipTLSValidation(true))
parameter 'logger' seems to be unused, consider removing or renaming it as _
185 return lc.credhub, nil
186}
187
188func (manager CredHubManager) Close(logger lager.Logger) {189 // TODO - to implement
190}
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}