else
/ elif
used after return
PYL-R1705 57 returns the request thread.
58 """
59 kwargs["_return_http_data_only"] = True
60 if kwargs.get("async_req"): 61 return self.list_webhook_jobs_with_http_info(
62 project_name_or_id, policy_id, **kwargs
63 ) # noqa: E501
464 returns the request thread.
465 """
466 kwargs["_return_http_data_only"] = True
467 if kwargs.get("async_req"): 468 return self.get_webhook_policy_of_project_with_http_info(
469 project_name_or_id, webhook_policy_id, **kwargs
470 ) # noqa: E501
728 returns the request thread.
729 """
730 kwargs["_return_http_data_only"] = True
731 if kwargs.get("async_req"): 732 return self.list_webhook_policies_of_project_with_http_info(
733 project_name_or_id, **kwargs
734 ) # noqa: E501
884 returns the request thread.
885 """
886 kwargs["_return_http_data_only"] = True
887 if kwargs.get("async_req"): 888 return self.update_webhook_policy_of_project_with_http_info(
889 project_name_or_id, webhook_policy_id, policy, **kwargs
890 ) # noqa: E501
52 returns the request thread.
53 """
54 kwargs["_return_http_data_only"] = True
55 if kwargs.get("async_req"): 56 return self.create_webhook_policy_of_project_with_http_info(
57 project_name_or_id, policy, **kwargs
58 ) # noqa: E501
The use of else
or elif
becomes redundant and can be dropped if the last statement under the leading if
/ elif
block is a return
statement.
In the case of an elif
after return
, it can be written as a separate if
block.
For else
blocks after return
, the statements can be shifted out of else
. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
def classify_number(x):
if x % 2 == 0:
return 'Even'
else:
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
elif x % 2 == 0 and x < 0:
return 'Even and Negative'
elif x % 2 != 0 and x < 0:
return 'Odd and Negative.'
else:
return 'Odd'
def classify_number(x):
if x % 2 == 0:
return 'Even'
return 'Odd'
def what_is_this_number(x):
if x % 2 == 0 and x >= 0:
return 'Even'
if x % 2 == 0 and x < 0:
return 'Even and Negative'
if x % 2 != 0 and x < 0:
return 'Odd and Negative'
return 'Odd'