PYL-W0622 · Re-definition found for builtin function

container-registry / harbor-api-client

Active

Re-definition found for builtin function PYL-W0622

Anti-pattern

Major

9 months ago — a year old

Redefining built-in 'type'

src/harbor_client/models/webhook_target_object.py

 47    }
 48
 49    def __init__(
 50        self, type=None, address=None, auth_header=None, skip_cert_verify=None, _configuration=None 51    ):  # noqa: E501
 52        """WebhookTargetObject - a model defined in Swagger"""  # noqa: E501
 53        if _configuration is None:

Redefining built-in 'type'

src/harbor_client/models/schedule_obj.py

 37    attribute_map = {"type": "type", "cron": "cron", "next_scheduled_time": "next_scheduled_time"}
 38
 39    def __init__(
 40        self, type=None, cron=None, next_scheduled_time=None, _configuration=None 41    ):  # noqa: E501
 42        """ScheduleObj - a model defined in Swagger"""  # noqa: E501
 43        if _configuration is None:

Redefining built-in 'type'

src/harbor_client/models/registry_ping.py

 55    def __init__(
 56        self,
 57        id=None,
 58        type=None, 59        url=None,
 60        credential_type=None,
 61        access_key=None,

Redefining built-in 'type'

src/harbor_client/models/registry_info.py

 50
 51    def __init__(
 52        self,
 53        type=None, 54        description=None,
 55        supported_resource_filters=None,
 56        supported_triggers=None,

Redefining built-in 'type'

src/harbor_client/models/registry_credential.py

 37    attribute_map = {"type": "type", "access_key": "access_key", "access_secret": "access_secret"}
 38
 39    def __init__(
 40        self, type=None, access_key=None, access_secret=None, _configuration=None 41    ):  # noqa: E501
 42        """RegistryCredential - a model defined in Swagger"""  # noqa: E501
 43        if _configuration is None:

Description

Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.

Bad practice

dict = {}  # dict is a Python builtin!
for idx, student in enumerate(students):
    dict[student] = idx

Preferred:

roll_number = {}
for idx, student in enumerate(students):
    roll_number[student] = idx