convox / convox

Function call can be replaced with helper function CRT-A0010
Anti-pattern
Major
7 days agoa year old
use strings.ReplaceAll method in strings.Replace(s, fmt.Sprintf("$%s", k), v, -1)
771func replaceEnv(s string, env map[string]string) string {
772	for k, v := range env {
773		s = strings.Replace(s, fmt.Sprintf("${%s}", k), v, -1)
774		s = strings.Replace(s, fmt.Sprintf("$%s", k), v, -1)775	}
776
777	return s
use strings.ReplaceAll method in strings.Replace(s, fmt.Sprintf("${%s}", k), v, -1)
770
771func replaceEnv(s string, env map[string]string) string {
772	for k, v := range env {
773		s = strings.Replace(s, fmt.Sprintf("${%s}", k), v, -1)774		s = strings.Replace(s, fmt.Sprintf("$%s", k), v, -1)
775	}
776
use strings.ReplaceAll method in strings.Replace(strings.ToUpper(r.Name), "-", "_", -1)
29type Resources []Resource
30
31func (r Resource) DefaultEnv() string {
32	return fmt.Sprintf("%s_URL", strings.Replace(strings.ToUpper(r.Name), "-", "_", -1))33}
34
35func (r Resource) LoadEnv() []string {
use bytes.ReplaceAll method in bytes.Replace(data, []byte("\n\n\tr.Route"), []byte("\n\tr.Route"), -1)
16
17	data = bytes.Replace(data, []byte("{\n\n"), []byte("{\n"), -1)
18	data = bytes.Replace(data, []byte("\n\n}"), []byte("\n}"), -1)
19	data = bytes.Replace(data, []byte("\n\n\tr.Route"), []byte("\n\tr.Route"), -1)20
21	return data, nil
22}
use bytes.ReplaceAll method in bytes.Replace(data, []byte("\n\n}"), []byte("\n}"), -1)
15	}
16
17	data = bytes.Replace(data, []byte("{\n\n"), []byte("{\n"), -1)
18	data = bytes.Replace(data, []byte("\n\n}"), []byte("\n}"), -1)19	data = bytes.Replace(data, []byte("\n\n\tr.Route"), []byte("\n\tr.Route"), -1)
20
21	return data, nil