Nested
if can be replaced with else if CRT-A0011
Anti-pattern
Major
12 hours ago
—
10 months old
can replace 'else {if cond {}}' with 'else if cond {}'
67 http.Error(w, "Unauthorized", http.StatusUnauthorized)
68 return
69 }
70 } else { 71 if password != p.Password {
72 http.Error(w, "Unauthorized", http.StatusUnauthorized)
73 return
Description
A single nested if inside an else block can be replaced with an else if.
It's better to have as little nesting as possible. Hence, it's cleaner to
replace a single nested if inside an else with an else-if.
Bad practice
if cond1 {
// do something
} else {
if x := cond2; x {
// do something else
}
}
Recommended
if cond1 {
// do something
} else if x := cond2; x {
// do something else
}