switch with single case can be rewritten as if or if-else CRT-A0014
Anti-pattern
Minor
15 hours ago
—
a year old
should rewrite switch statement to if statement
254 defaults := map[string]string{}
255
256 for _, e := range s.Environment {
257 switch parts := strings.Split(e, "="); len(parts) {258 case 2:
259 defaults[parts[0]] = parts[1]
260 }should rewrite switch statement to if statement
652
653 if css := pd.Status.ContainerStatuses; len(css) > 0 && css[0].Name == app {
654 if cs := css[0]; cs.State.Waiting != nil {
655 switch cs.State.Waiting.Reason {656 case "CrashLoopBackOff":
657 status = "crashed"
658 }should rewrite switch statement to if statement
249
250 a.Parameters = params
251
252 switch ns.Status.Phase {253 case "Terminating":
254 a.Status = "deleting"
255 }should rewrite switch statement to if statement
83 for _, a := range m.Args {
84 if a.Path(m) {
85 ft := "%s"
86 switch a.Type.Kind() { 87 case reflect.Int:
88 ft = "%d"
89 }
Description
switch statements with a single case can be rewritten as if-else or if.
Single case switch can be replaced by if-else as it appears to be more
readable. This does not apply to type switch.
Bad practice
switch ok {
case true:
// body
}
Recommended
if ok {
// body
}