Function literal can be simplified CRT-A0018
Anti-pattern
Major
18 hours ago
—
a year old
replace
func(v string) (string, error) {
return volumeTo(v)
} with volumeTo120 "volumeName": func(app, v string) string {
121 return p.volumeName(app, v)
122 },
123 "volumeTo": func(v string) (string, error) {124 return volumeTo(v)
125 },
126 }replace
func(s string) string {
return strings.ToUpper(s)
} with strings.ToUpper108 "systemVolume": func(v string) bool {
109 return systemVolume(v)
110 },
111 "upper": func(s string) string {112 return strings.ToUpper(s)
113 },
114 "volumeFrom": func(app, service, v string) string {replace
func(v string) bool {
return systemVolume(v)
} with systemVolume105 "systemHost": func() string {
106 return p.Engine.SystemHost()
107 },
108 "systemVolume": func(v string) bool {109 return systemVolume(v)
110 },
111 "upper": func(s string) string {replace
func(s string) ([]string, error) {
return shellquote.Split(s)
} with shellquote.Split 91 "safe": func(s string) template.HTML {
92 return template.HTML(fmt.Sprintf("%q", s))
93 },
94 "shellsplit": func(s string) ([]string, error) { 95 return shellquote.Split(s)
96 },
97 "sortedKeys": func(m map[string]string) []string {replace
func(s string) string {
return strings.ToLower(s)
} with strings.ToLower 82 "k8sname": func(s string) string {
83 return nameFilter(s)
84 },
85 "lower": func(s string) string { 86 return strings.ToLower(s)
87 },
88 "quoteEscape": func(s string) string {
Description
Function literals that only call a single function, without making any other changes to the value of the inner function, can be removed, as they are redundant. Instead, the inner function, that is being called inside the outer function should be called.
Bad practice
_ = func(x int, y int) int { return add(x, y) }(1, 2)
Recommended
_ = add(1, 2)