Use
t.Setenv and friends instead of os.Setenv for test file(s) GO-W1032
Bug risk
Major
12 days ago
—
a year old
os.Setenv() can be replaced by 't.Setenv()' in testProvider
102 _, err = c.CoreV1().Namespaces().Create(context.TODO(), &ac.Namespace{ObjectMeta: am.ObjectMeta{Name: "test"}}, am.CreateOptions{})
103 require.NoError(t, err)
104
105 os.Setenv("NAMESPACE", "test")106
107 fn(p)
108os.Setenv() can be replaced by 't.Setenv()' in testProvider
64 _, err = c.CoreV1().Namespaces().Create(context.TODO(), &ac.Namespace{ObjectMeta: am.ObjectMeta{Name: "test"}}, am.CreateOptions{})
65 require.NoError(t, err)
66
67 os.Setenv("NAMESPACE", "test") 68
69 pp := &aws.Provider{
70 Provider: p,
Description
For tests, environment variables are sometimes temporarily set. It is also essential and
even a good practice to unset those temporary values as they might interfere with others
trying to use the same environment variable. It is recommended that for *_test.go file(s)
one should use Setenv method from the "testing" package as it unsets the same after the
test has concluded. Following Setenv calls os.Setenv(key, value) and uses Cleanup to
restore the environment variable to its original value after the test.
Bad practice
func setup() {
os.Setenv("a", "b")
}
func TestF(t *testing.T) {
os.Setenv("a", "b")
}
func TB(tb testing.TB) {
os.Setenv("a", "b")
}
func FuzzF(f *testing.F) {
os.Setenv("a", "b")
}
Recommended
func setup() {
testing.Setenv("a", "b")
}
func TestF(t *testing.T) {
t.Setenv("a", "b")
}
func TB(tb testing.TB) {
tb.Setenv("a", "b")
}
func FuzzF(f *testing.F) {
f.Setenv("a", "b")
}