Redundant error checking RVV-B0005
Style
Major
14 days ago
—
a year old
redundant if ...; err != nil check, just return error instead.
309 },
310 }
311
312 if err := c.Delete("/registries", ro, nil); err != nil {313 return err
314 }
315redundant if ...; err != nil check, just return error instead.
232 return err
233 }
234
235 if err := c.Post(fmt.Sprintf("/apps/%s/formation/%s", app, service), ro, nil); err != nil {236 return err
237 }
238redundant if ...; err != nil check, just return error instead.
31 ro.Params[k] = v
32 }
33
34 if err := c.Post(fmt.Sprintf("/apps/%s/parameters", name), ro, nil); err != nil { 35 return err
36 }
37redundant if ...; err != nil check, just return error instead.
43 return err
44 }
45
46 if err := p.Provider.Initialize(opts); err != nil {47 return err
48 }
49redundant if ...; err != nil check, just return error instead.
16 "stream": stream,
17 }
18
19 if err := p.elastic.Write(index, ts, message, tags); err != nil {20 return err
21 }
22
Description
Some simple error checking patterns can be reduced to just a single return
statement returning a variable of type Error.
Bad practice
if err != nil {
return err
}
return nil
Recommended
return err