Unused parameter in function RVV-B0012
Bug risk
Minor
6 days ago
—
a year old
parameter 'app' seems to be unused, consider removing or renaming it as _
2
3import "fmt"
4
5func (p *Provider) RepositoryAuth(app string) (string, string, error) { 6 return "docker", p.Secret, nil
7}
8parameter 'm' seems to be unused, consider removing or renaming it as _
4 "github.com/convox/convox/pkg/manifest"
5)
6
7func (p *Provider) ManifestValidate(m *manifest.Manifest) error {8 return nil
9}
parameter 'app' seems to be unused, consider removing or renaming it as _
2
3import "fmt"
4
5func (p *Provider) RepositoryAuth(app string) (string, string, error) { 6 return "docker", p.Secret, nil
7}
8parameter 'm' seems to be unused, consider removing or renaming it as _
4 "github.com/convox/convox/pkg/manifest"
5)
6
7func (p *Provider) ManifestValidate(m *manifest.Manifest) error {8 return nil
9}
parameter 'cur' seems to be unused, consider removing or renaming it as _
97 return nil
98}
99
100func (c *PodController) Update(prev, cur interface{}) error {101 return nil
102}
103
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}