time.Tick used in leaky way SCC-SA1015
Performance
Critical
14 days ago
—
a year old
using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here
499 Ignores: ignores,
500 })
501
502 tick := time.Tick(1000 * time.Millisecond)503 var chgs []changes.Change
504
505 for {using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here
428}
429
430func (opts Options2) waitForBuild(ctx context.Context, id string) error {
431 tick := time.Tick(1 * time.Second)432
433 for {
434 select {
Description
Using time.Tick in a way that will leak. Consider using time.NewTicker, and
only use time.Tick in tests, commands and endless functions.
Bad practice
import (
"fmt"
"time"
)
func foo() {
c := time.Tick(5 * time.Second)
for next := range c {
fmt.Println(next)
// No way to cancel or reset the timer
}
}
Recommended
import (
"fmt"
"time"
)
func foo() {
ticker := time.NewTicker(5 * time.Second)
go func() {
time.Sleep(20 * time.Second)
ticker.Stop()
}()
for next: = range ticker.C {
fmt.Println(next)
// Will only go until the first 20 seconds
}
}