Issues with
cancel func returned by context.WithCancel VET-V0011
Bug risk
Major
12 days ago
—
a year old
the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
38
39 fmt.Printf("ns=rack at=signal signal=%v terminate=true\n", sig)
40
41 ctx, _ := context.WithTimeout(context.Background(), 10*time.Second)42 r.Shutdown(ctx)
43
44 os.Exit(0)the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
40
41 fmt.Printf("ns=rack at=signal signal=%v terminate=true\n", sig)
42
43 ctx, _ := context.WithTimeout(context.Background(), 10*time.Second)44 s.Shutdown(ctx)
45
46 os.Exit(0)
Description
The cancellation function returned by context.WithCancel, WithTimeout, and
WithDeadline must be called or the new context will remain live until its
parent context is cancelled. (The background context is never cancelled.)
This is usually an issue either because the variable was assigned to the blank identifier, or because there exists a control-flow path from the call to a return statement and that path does not "use" the cancel function.
For example, cancel is not used on all paths below, hence, is an issue.
func f(cond bool) {
var _, cancel = context.WithCancel(bg)
if cond {
x = cancel
}
}