Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
a year ago
—
a year old
Unexpected string concatenation
15 employee.getRole() === "Engineer" ? "laptop" :
16 "graduation cap";
17 const item = $("<div>").addClass("item");
18 const logo = $("<i>").addClass(iconName + " big icon"); 19 const content = $("<div>").addClass("content")
20 const header = $("<div>").addClass("header").text(employee.getRole());
21 const description = $("<div>").addClass("description").text(employee.getName());Unexpected string concatenation
306const writeToFile = (documentName, documentBody) => {
307 let fileName = "./dist/" + documentName;
308 fs.writeFile(fileName, documentBody, (err) =>
309 err ? console.error(err) : console.log("HTML document successfully created at " + fileName));310
311}
312Unexpected string concatenation
304let documentName = '';
305
306const writeToFile = (documentName, documentBody) => {
307 let fileName = "./dist/" + documentName;308 fs.writeFile(fileName, documentBody, (err) =>
309 err ? console.error(err) : console.log("HTML document successfully created at " + fileName));
310
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";