JS-0239 @ 5f2d907 • danielfloresd / team-profile-generator

Run summary

a year ago

67722fb..5f2d907

18 s

Consider using let or const instead of var JS-0239

Anti-pattern

Major

5 occurrences in this check

Unexpected var, use let or const instead

public/js/script.js

134        let html = generateHTML(team);
135        // Download generated html as a file
136        // Open window to download file to local machine
137        var file = new Blob([html], { type: 'text/html' });138        element.href = URL.createObjectURL(file);
139        element.download = "team.html";
140        element.click();

Unexpected var, use let or const instead

public/js/script.js

130    
131    $("#download").on("click", function () {
132        // Add download markdown as a file
133        var element = document.createElement("a");134        let html = generateHTML(team);
135        // Download generated html as a file
136        // Open window to download file to local machine

Unexpected var, use let or const instead

public/js/script.js

122        var element = document.createElement("a");
123        let html = generateHTML(team);
124        // Open a new window with the generated HTML
125        var win = window.open();126        win.document.write(html);
127        win.document.close();
128    });

Unexpected var, use let or const instead

public/js/script.js

119
120    $("#generate").on("click", function () {
121        // Add download markdown as a file
122        var element = document.createElement("a");123        let html = generateHTML(team);
124        // Open a new window with the generated HTML
125        var win = window.open();

Unexpected var, use let or const instead

public/js/script.js

 29
 30function generateDocument(data) {
 31
 32    var html = generateHTML(data); 33
 34    $("#html-preview").html(html);
 35    $("#preview-modal").modal("show");

Description

It is recommended to use let or const over var. This will help prevent re-declaration of variables that are in the global scope when using var.

ES6 allows programmers to create variables with block scope instead of function scope using the let and const keywords. Block scope is common in many other programming languages and helps programmers avoid mistakes such as this one:

var count = people.length;
var enoughFood = count > sandwiches.length;

if (enoughFood) {
    var count = sandwiches.length; // accidentally overriding the count variable
    console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}

// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");

Block scoped variables shadow outer declarations instead of writing to them.

NOTE: There are certain edge cases where users might want to consider var. Consider this example:

var lib = lib || { run: () => {} }

Here, lib might be a library that is exposed to an HTML file using a <script> tag. The var keyword helps avoid re-writing lib if it has already been declared via an injected script that was executed before this one. Ideally, you should let bundlers worry about cases like this. But if you want to use var anyway, consider using a skipcq comment, or disabling the issue altogether.

Bad Practice

var x = "y";
var CONFIG = {};

danielfloresd / team-profile-generator

Bad Practice

Recommended