Double assignment of variable detected JAVA-E1063
Bug risk
Major
8 months ago
—
8 months old
conn is assigned twice here, was this intended?
37
38 try {
39 conn =
40 conn = DriverManager.getConnection(DB_URL, "user", ""); 41 Statement s = conn.createStatement();
42 s.execute("SELECT userName, isWin FROM users WHERE uid = " + req.getParameter("ticket") + ";");
43 ResultSet r = s.getResultSet();
Description
A double assignment of a variable to itself has been detected. This may be a typo.
Check whether this is correct and edit it or remove the extra assignment.
When used as an expression, an assignment evaluates to the result of the RHS expression. For example, in the assignment a = 3, Java would evaluate the result of the assignment as 3.
Bad Practice
Assigning a value to itself is redundant and does not achieve any benefits over assigning just the value of the RHS expression.
someVar = someVar = ...; // redundant!
Recommended
It is likely that this was a typo. Perhaps the intention was to use a different variable in place of one of the repeated names.
someVar = someOtherVar = ...;
Alternatives
Consider changing this double assignment into two single, separate assignments on different lines.
someVar = ...;
someOtherVar = someVar;
This can have multiple benefits:
- It is clear where an assignment occurs.
- It is easier to understand what value is being assigned to what variable.
- It improves readability.