PTC-W0904 · Consider using `TextField` instead of `CharField`

Consider using TextField instead of CharField PTC-W0904

Anti-pattern

Major

9 months ago — 9 months old

Consider converting ticket into a TextField

73
74class SessionTicket(models.Model):
75    session_key = models.CharField(max_length=SESSION_KEY_MAXLENGTH)
76    ticket = models.CharField(max_length=1024)77
78    @classmethod
79    def clean_deleted_sessions(cls) -> None:

Description

CharField highlighted in the issue has a max_length > 256. It is recommended to use TextField for such long fields. CharField should only be used for smaller strings.

Reasons to fix this:

More readable and maintainable. Any developer reading the code in the future doesn't have to wonder about the specific max_length.
If for some reason, the current max_length needs to be increased, you'd need to create a new database migration to facilitate this change.

Not Preferred:

class MyModel(models.Model):
    my_field = models.CharField(max_length=1000)

Preffered:

class MyModel(models.Model):
    my_field = models.TextField()

django-cas-ng / django-cas-ng

Not Preferred:

Preffered: