Found empty block statements JS-0009
Anti-pattern
Minor
a year ago
—
a year old
Empty block statement
23
24try {
25 document.getElementById("month").innerText = getCurrentMonth();
26} catch (err) {}27
28exports.getCurrentMonth = getCurrentMonth;
29exports.isAdmin = isAdmin;Empty block statement.
1(()=>{try{document.getElementById("month").innerText=((e=new Date)=>["January","February","March","April","May","June","July","August","September","October","November","December"][e.getMonth()])()}catch(e){}})();
Description
Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can mislead the reader.
If you still want to keep an empty block, add a comment saying empty inside the block.
Bad Practice
if (someCheck) {}
while (someCheck) {}
try {
doSomething();
} catch(err) {
} finally {
}
Recommended
if (someCheck) {
// empty
}
while (someCheck) {
/* empty */
}
try {
doSomething();
} catch (err) {
// continue regardless of error
}
try {
doSomething();
} finally {
/* continue regardless of error */
}