JS-0127 · Found `undefined` as an Identifier

Found undefined as an Identifier JS-0127

Bug risk

Minor

2 years ago — 2 years old

Unexpected use of undefined

  1const resetVariables = () => {
  2  fail = false;
  3  error = undefined;  4
  5  lastUrl = location.href;
  6  isWhitelist = false;

Unexpected use of undefined

inject/00-init/3-functions.js

 49  dcconSelectorCursor = -1;
 50  iconSelectorCursorArrowCount = 0;
 51
 52  imageTippyInstance = undefined; 53  thumbnailTippyInstance = undefined;
 54  inputTippyInstance = undefined;
 55}

Unexpected use of undefined

inject/00-init/3-functions.js

 43
 44  iconSelectorRoot = undefined;
 45  iconSelectorListWrapper = undefined;
 46  iconSelectorList = undefined; 47  isSelectorOpen = false;
 48  showSelector = true;
 49  dcconSelectorCursor = -1;

Unexpected use of undefined

inject/00-init/3-functions.js

 42  isChatHidden = false;
 43
 44  iconSelectorRoot = undefined;
 45  iconSelectorListWrapper = undefined; 46  iconSelectorList = undefined;
 47  isSelectorOpen = false;
 48  showSelector = true;

Unexpected use of undefined

inject/00-init/3-functions.js

 41  streamChatObserver = undefined;
 42  isChatHidden = false;
 43
 44  iconSelectorRoot = undefined; 45  iconSelectorListWrapper = undefined;
 46  iconSelectorList = undefined;
 47  isSelectorOpen = false;

Description

The undefined variable in JavaScript is actually a property of the global object. As such, in ECMAScript 3 it was possible to overwrite the value of undefined. While ECMAScript 5 disallows overwriting undefined, it's still possible to shadow undefined, such as:

function doSomething(data) {
    var undefined = "hi";

    // doesn't do what you think it does
    if (data === undefined) {
        // ...
    }
}

Because undefined can be overwritten or shadowed, reading undefined can give an unexpected value. (This is not the case for null, which is a keyword that always produces the same value.) To guard against this, you can avoid all uses of undefined.

This ensures that undefined will always hold its original, expected value.

Bad Practice

var foo = undefined;

var undefined = "foo";

if (foo === undefined) {
    // ...
}

function foo(undefined) {
    // ...
}

drowsy-probius / twitch-icon-selector

Bad Practice

Recommended