Class methods should utilize
this JS-0105
Anti-pattern
Minor
a year ago
—
a year old
Expected 'this' to be used by class method 'getProperty'
4
5@singleton()
6export class EnvPropertyResolutionEngine implements IPropertyResolutionEngine {
7 public getProperty(prop: string): PropertyTYpe { 8 return process.env[prop] ?? null;
9 }
10}
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();