PYL-W0613 · Function contains unused argument

dvershinin / lastversion

Active

Function contains unused argument PYL-W0613

Anti-pattern

Major

3 months ago — 2 years old

Unused argument 'shorter'

src/lastversion/repo_holders/sourceforge.py

49            f"https://{self.hostname}/projects/{self.repo}/rss?path=/", pre_ok, major
50        )
51
52    def release_download_url(self, release, shorter=False):53        """Get download URL for a release."""
54        return self.get_normalized_url(release["link"])

Unused argument 'shorter'

src/lastversion/repo_holders/pypi.py

40            self.hostname = PypiRepoSession.DEFAULT_HOSTNAME
41        self.project = self.get_project()
42
43    def release_download_url(self, release, shorter=False):44        """Get release download URL."""
45        for f in release["files"]:
46            if f["packagetype"] == "sdist":

Unused argument 'shorter'

src/lastversion/repo_holders/wordpress.py

38            self.hostname = WordPressPluginRepoSession.DEFAULT_HOSTNAME
39        self.project = self.get_project()
40
41    def release_download_url(self, release, shorter=False):42        """Get release download URL."""
43        return f'https://downloads.wordpress.org/plugin/{self.repo}.{release["version"]}.zip'
44

Description

An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.

Bad practice

def square(x, y=1):
    return x * x

class MySubClass(MyClass):
    def __init__(self, number):
        self.value = 42  # argument `number` remains unused

Preferred:

def square(x):
    return x * x

class MySubClass(MyClass):
    def __init__(self, _):
        self.value = 42