urllib detected BAN-B310309 # Get an unique identifier from uuid if not provided
310 filename = f'{get_file_name()}.{ext}'
311 if image_file:
312 with urllib.request.urlopen(image_file) as img_data:313 image_file = io.BytesIO(img_data.read())
314 else:
315 file_relative_path = 'static/default_system_image.png'urllib not only opens http:// or https:// URLs, but also ftp:// and file://.
With this, it might be possible to open local files on the executing machine which might be a security risk if the URL to open can be manipulated by an external user.
The urllib.request module defines functions and classes which help in opening URLs. urllib.request.open can open ftp:// and file:// URLs. This is usually not intended and makes the application vulnerable to Server Side Request Forgery attack.
Performing requests from user-provided data could allow attackers to make requests on the internal network or change, retrieve or delete sensitive information. You are yourself responsible for validating the URL before opening it with urllib.
It is recommended to validate the user-provided data, such as the URL and headers used to construct the request.
Since this is an audit issue, some occurrences may be harmless here. The goal is to bring the issue in attention. Please make sure that the url is trusted. If the occurrences doesn't seem to be valid, please feel free to ignore them.
Bad practice
req = urllib.Request.request(url)
resp = urllib.request.urlopen(req)
Recommended
# Validate URL before opening it
if url.lower().startswith('http'):
req = urllib.Request.request(url)
else:
raise ValueError from None
with urllib.request.urlopen(req) as resp:
[...]
## References:
- OWASP Top 10 2021 Category A10 - [Server Side Request Forgery](https://owasp.org/Top10/A10_2021-Server-Side_Request_Forgery_%28SSRF%29/)
- [CWE-918](https://cwe.mitre.org/data/definitions/918.html) - Server-Side Request Forgery (SSRF)