if statements can be merged PTC-W0048
Anti-pattern
Major
5 months ago
—
3 years old
Consider merging collapsible if statements
109
110 def before_delete_object(self, users_groups_roles, view_kwargs):
111 role = users_groups_roles.role
112 if role:113 if role.name == "owner":
114 raise ForbiddenError(
115 {'source': 'Role'},Consider merging collapsible if statements
96 {'event_id': data['event']}, "Event does not exist"
97 )
98
99 if data.get('type') == 'paid' or data.get('type') == 'donation':100 if not event.is_payment_enabled():
101 raise UnprocessableEntityError(
102 {'event_id': data['event']},Consider merging collapsible if statements
147 session = safe_query_kwargs(Session, view_kwargs, 'session_id')
148 # session-speaker :: many-to-many relationship
149 query_ = Speaker.query.filter(Speaker.sessions.any(id=session.id))
150 if is_logged_in() and not has_access(151 'is_coorganizer', event_id=session.event_id
152 ):
153 if not has_access('is_session_self_submitted', session_id=session.id):Consider merging collapsible if statements
140 """
141 if not speaker_invite:
142 return
143 if not speaker_invite.email == current_user.email:144 if not has_access('is_speaker_for_session', id=speaker_invite.session_id):
145 raise ForbiddenError(
146 {'source': ''}, 'Speaker or Invitee access is required.'Consider merging collapsible if statements
41 require_relationship(['session', 'event'], data)
42 if not has_access('is_speaker_for_session', id=data['session']):
43 raise ForbiddenError({'source': ''}, 'Speaker access is required.')
44 if data.get('status'): 45 if not data['status'] == 'pending':
46 raise ForbiddenError(
47 {'source': ''}, 'Speaker Invite can not created with accepted status.'
Description
Nested if statements can be collapsed into a single if statement by separating their condition using and operator.
Merging collapsible if statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.