Logical operators used when combining SQL column expressions PY-W0800
Bug risk
Major
5 months ago
—
a year old
Logical operators used when combining SQL column expressions
152 elif view_kwargs.get('user_id'):
153 user = safe_query_kwargs(User, view_kwargs, 'user_id')
154 query_ = (
155 query_.join(Session.speakers)156 .filter(
157 Session.creator_id == user.id
158 or Session.speakers.any(
Description
Column expressions inside a sqlalchemy where or having clause must be combined using the bitwise & and | operators, not the logical and / or. Using logical operators cause various expressions to be ignored, leading to unintended behaviour.
You can read about the ways to combine SQL expressions in sqlalchemy here.
Bad practice
from sqlalchemy import select
select([user.id, user.name]).where(
(user.org == my_org) and (user.active == True) # Using `and` here won't work as you expect.
)
Recommended
from sqlalchemy import select
select([user.id, user.name]).where(
(user.org == my_org) & (user.active == True) # Replaced `and` with bitwise `&`.
)