Function or method is being redefined PYL-E0102
Bug risk
Major
5 months ago
—
3 years old
function already defined line 48
77 assert json.loads(response.data) == {"can_access": True, "exists": True}
78
79
80def test_event_stream_rooms_identifier(db, client, user, jwt):81 event = EventFactoryBasic(state='published')
82 MicrolocationSubVideoStreamFactory(event=event)
83 AttendeeOrderSubFactory(event=event, email=user.email, order__status='completed')function already defined line 38
66 assert json.loads(response.data) == {"can_access": True, "exists": True}
67
68
69def test_event_stream_rooms(db, client, user, jwt):70 event = EventFactoryBasic(state='published')
71 MicrolocationSubVideoStreamFactory(event=event)
72 AttendeeOrderSubFactory(event=event, email=user.email, order__status='completed')
Description
A function, method or class is being redefined in the same scope. This would override the original definition, and doing this is strongly discouraged. Please verify that this is something that you intended to do. Redefining anything can lead to confusion, decreases code readability and may cause bugs that are difficult to diagnose. It is recommended either to refactor the function/method/class, or choose different names.
Bad practice
def calc(x, y):
return x + y
def calc(x, y):
return x * y
Recommended
def calc_sum(x, y):
return x + y
def calc_product(x, y):
return x * y