Statement not reachable on execution PYL-W0101
Anti-pattern
Critical
5 months ago
—
3 years old
Unreachable code
98def notify_ticket_purchase_organizer(order):
99 # TODO: Need to discuss behaviour
100 return
101 event = order.event102 users = event.notify_staff
103 content = NotificationContent(
104 type=NotificationType.TICKET_PURCHASED_ORGANIZER,
Description
This statement is unreachable, as the control flow will never reach upto this point. Consider removing this part of code or re-evaluating the control flow.
Bad practice
def count_pairs(users):
pairs = 0
for user in users:
if user.type == "student":
pairs += 1
return pairs
pairs /= 2 # <-- Unreachable
Preferred
def count_pairs(users):
pairs = 0
for user in users:
if user.type == "student":
pairs += 1
pairs /= 2
return pairs