Statement has no effect PYL-W0104
Anti-pattern
Major
5 months ago
—
4 years old
Statement seems to have no effect
48
49
50def test_notify_session_state_change(db, session):
51 session.state == 'accepted' 52 session.speakers = [SpeakerSubFactory(email='[email protected]')]
53 user = UserFactory(_email='[email protected]')
54 db.session.commit()Statement seems to have no effect
97 raise ForbiddenError({'source': ''}, 'Access Forbidden')
98 # access_code - ticket :: many-to-many relationship
99 query_ = AccessCode.query.filter(AccessCode.tickets.any(id=ticket.id))
100 query_101 return query_
102
103 view_kwargs = True
Description
The expression or statement is pointless and will not affect the program's execution. It should be removed.
It is recommended to remove the statement as it adds unnecessary complexity to the codebase.
Bad practice
x = input()
x == 3 # Line doesn't do anything, it can be safely removed
calculate_res(x)
Preferred:
x = input()
calculate_res(x)