.bind() or local functions in JSX properties JS-0417117 </div>
118 </form>
119 </div>
120 <EditFormButtonDiv toggleEdit={toggleEdit} />121 </div>
122 </div>
123 );111 <input type="radio" name="todopriorityedit" value="Standard" id="Standard" onChange={handleInputChange}
112 checked={priority === "Standard"}/>
113 <label htmlFor="Standard">Standard</label>
114 <input type="radio" name="todopriorityedit" value="High" id="High" onChange={handleInputChange}115 checked={priority === "High"}/>
116 <label htmlFor="High">High</label></div>
117 </div> 93 <div className="checkbox">✓</div>
94 </div>
95 <div className="duringedit">
96 <form className="todocontent" id="editform" onSubmit={handleSubmit}> 97 <div className="inputdiv"><label htmlFor="todotitleedit">Title:</label>
98 <input type="text" name="todotitleedit" id="todotitleedit" required value={heading} onChange={handleInputChange}/>
99 </div> 95 <div className="duringedit">
96 <form className="todocontent" id="editform" onSubmit={handleSubmit}>
97 <div className="inputdiv"><label htmlFor="todotitleedit">Title:</label>
98 <input type="text" name="todotitleedit" id="todotitleedit" required value={heading} onChange={handleInputChange}/> 99 </div>
100 <div className="inputdiv"><label htmlFor="todocontentedit">Content (optional):</label>
101 <input type="text" name="todocontentedit" id="todocontentedit" value={text} onChange={handleInputChange}/> 98 <input type="text" name="todotitleedit" id="todotitleedit" required value={heading} onChange={handleInputChange}/>
99 </div>
100 <div className="inputdiv"><label htmlFor="todocontentedit">Content (optional):</label>
101 <input type="text" name="todocontentedit" id="todocontentedit" value={text} onChange={handleInputChange}/>102 </div>
103 <div className="inputdiv"><label htmlFor="tododateedit">Due date:</label>
104 <input type="date" name="tododateedit" id="tododateedit" required value={date} onChange={handleInputChange}/>Using .bind() or passing local callback functions as props to react component incurs a performance overhead.
Consider using React.useCallback, or if possible, moving the callback definition outside the component.
EXCEPTIONS: This rule may not apply if your react component is only rendered once, or if your application is not performance sensitive. In such cases, consider adding a skipcq to prevent DeepSource from raising this issue on a single component. Alternatively, for small applications, you could add this issue in the ignore rules section.
Note that the performance overhead is not determined by the size of the callback function, but instead the number of times the component is rendered.
If the callback passed to a prop is local to the render function, it will get recreated every time the component renders.
This affects performance by causing unnecessary re-renders if a brand new function is passed as a property to a component that uses a reference equality check on the property to determine if it should update.
Using the useCallback hook on functional components, or a method on class components is more performant.
Bad Practice
function CardWrapper() {
// the function `handleClick` is recreated every time
// a `CardWrapper` component is rendered.
const handleClick = (e) => displayCardDetails(e)
return <Card onClick={handleClick} />
}
function CardWrapper_() {
return <Card onClick={(e) => displayCardDetails(e)} />
}
class _CardWrapper extends React.Component {
render() {
return <Card onClick={(e) => displayCardDetails(e)} />
}
}
Recommended
function CardWrapper() {
// `handleClick` is no longer recreated on every render.
const handleClick = React.useCallback((e) => displayCardDetails(e))
return <Card onClick={handleClick} />
}
class CardWrapper_ extends React.Component {
handleClick(e) {
displayCardDetails(e)
}
render() {
return <Card onClick={this.handleClick} />
}
}