strings.Index used to cut a string GO-W1008
Anti-pattern
Minor
6 months ago
—
a year old
strings.Index used to cut a string
18 eqIdx := strings.Index(expr, "=")
19 if eqIdx > 0 {
20 tagName := expr[:eqIdx]
21 neqIdx := strings.Index(expr, "!") 22 if neqIdx == -1 {
23 irondbOp = "and"
24 } else {
Description
Using strings.Index to divide a string using a separator is an antipattern.
Consider using strings.Cut instead.
Bad practice
idx := strings.Index(str, "@")
if idx == -1 {
return
}
left, right := str[:idx], str[idx+1:]
Recommended
left, right, ok := strings.Cut(str, "@")
if !ok {
return
}