Unused parameter in function RVV-B0012
Bug risk
3 months ago
—
2 years old
parameter 'ctx' seems to be unused, consider removing or renaming it as _
48}
49
50// Frees a slot in limiter
51func (sl RealLimiter) Leave(ctx context.Context, s string) {52 if sl.m == nil {
53 return
54 }parameter 'configFile' seems to be unused, consider removing or renaming it as _
19 interfaces.FunctionBase
20}
21
22func New(configFile string) []interfaces.RewriteFunctionMetadata { 23 res := make([]interfaces.RewriteFunctionMetadata, 0)
24 f := &applyByNode{}
25 for _, n := range []string{"applyByNode"} {parameter 'configFile' seems to be unused, consider removing or renaming it as _
20 return interfaces.Any
21}
22
23func New(configFile string) []interfaces.FunctionMetadata { 24 res := make([]interfaces.FunctionMetadata, 0)
25 f := &groupByNode{}
26 functions := []string{"groupByNode", "groupByNodes"}parameter 'limit' seems to be unused, consider removing or renaming it as _
9 "go.uber.org/zap"
10)
11
12func (c *VictoriaMetricsGroup) doTagQuery(ctx context.Context, isTagName bool, query string, limit int64, supportedFeatures *vmSupportedFeatures) ([]string, merry.Error) {13 logger := c.logger
14 var rewrite *url.URL
15 if isTagName {parameter 'ctx' seems to be unused, consider removing or renaming it as _
225func (c *ClientProtoV3Group) List(ctx context.Context) (*protov3.ListMetricsResponse, *types.Stats, merry.Error) {
226 return nil, nil, types.ErrNotImplementedYet
227}
228func (c *ClientProtoV3Group) Stats(ctx context.Context) (*protov3.MetricDetailsResponse, *types.Stats, merry.Error) {229 return nil, nil, types.ErrNotImplementedYet
230}
231
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}