Unused method receiver RVV-B0013
Bug risk
7 days ago
—
2 years old
Method receiver 'f' is not referenced in method's body, consider removing or renaming it as _
28 return res
29}
30
31func (f *applyByNode) Do(ctx context.Context, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) (bool, []string, error) { 32 args, err := helper.GetSeriesArg(ctx, e.Arg(0), from, until, values)
33 if err != nil {
34 return false, nil, errMethod receiver 'f' is not referenced in method's body, consider removing or renaming it as _
75}
76
77// Description is auto-generated description, based on output of https://github.com/graphite-project/graphite-web
78func (f *applyByNode) Description() map[string]types.FunctionDescription { 79 return map[string]types.FunctionDescription{
80 "applyByNode": {
81 Name: "applyByNode",Method receiver 'f' is not referenced in method's body, consider removing or renaming it as _
120}
121
122// Description is auto-generated description, based on output of https://github.com/graphite-project/graphite-web
123func (f *groupByNode) Description() map[string]types.FunctionDescription {124 return map[string]types.FunctionDescription{
125 "groupByNode": {
126 Description: "Takes a serieslist and maps a callback to subgroups within as defined by a common node\n\n.. code-block:: none\n\n &target=groupByNode(ganglia.by-function.*.*.cpu.load5,2,\"sumSeries\")\n\nWould return multiple series which are each the result of applying the \"sumSeries\" function\nto groups joined on the second node (0 indexed) resulting in a list of targets like\n\n.. code-block :: none\n\n sumSeries(ganglia.by-function.server1.*.cpu.load5),sumSeries(ganglia.by-function.server2.*.cpu.load5),...\n\nNode may be an integer referencing a node in the series name or a string identifying a tag.\n\nThis is an alias for using :py:func:`groupByNodes <groupByNodes>` with a single node.",Method receiver 'p' is not referenced in method's body, consider removing or renaming it as _
15 BroadcastLB
16)
17
18func (p LBMethod) keys(m map[string]LBMethod) []string {19 res := make([]string, 0)
20 for k := range m {
21 res = append(res, k)Method receiver 'c' is not referenced in method's body, consider removing or renaming it as _
225func (c *ClientProtoV3Group) List(ctx context.Context) (*protov3.ListMetricsResponse, *types.Stats, merry.Error) {
226 return nil, nil, types.ErrNotImplementedYet
227}
228func (c *ClientProtoV3Group) Stats(ctx context.Context) (*protov3.MetricDetailsResponse, *types.Stats, merry.Error) {229 return nil, nil, types.ErrNotImplementedYet
230}
231
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}