Drop unnecessary use of the blank identifier SCC-S1005
Anti-pattern
Major
5 months ago
—
4 years old
unnecessary assignment to the blank identifier
296 }
297
298 if alignToInterval != "" {
299 for i, _ := range r {300 newStart, err := StartAlignTo(r[i].From, alignToInterval)
301 if err != nil {
302 return nilunnecessary assignment to the blank identifier
273 interval := int64(bucketSizeInt32)
274 // This is done in order to replicate the behavior in Graphite web when alignToInterval is set,
275 // in which new data is fetched with the adjusted start time.
276 for i, _ := range r {277 start := r[i].From
278 for _, v := range []int64{86400, 3600, 60} {
279 if interval >= v {
Description
Assigning to the blank identifier is unnecessary.
From the Go spec:
If the last iteration variable is the blank identifier, the range clause is equivalent to the same clause without that identifier.
Bad practice
for _ = range slc {}
x, _ = someMap[key]
_ = <-ch
Recommended
for range slc {}
x = someMap[key]
<-ch