Simplify
make call by omitting redundant arguments SCC-S1019
Anti-pattern
Major
5 months ago
—
4 years old
should use make([]*types.MetricData, 0) instead
43 if len(seriesList1) != len(seriesList2) {
44 return nil, fmt.Errorf("seriesListFirstPos and seriesListSecondPos must have equal length")
45 } else if len(seriesList1) == 0 {
46 return make([]*types.MetricData, 0, 0), nil 47 }
48
49 aggFuncStr, err := e.GetStringArg(2)
Description
The make function has default values for the length and capacity arguments.
- For channels and maps, the length defaults to zero.
- For slices the capacity defaults to the length.
Bad practice
ch = make(chan int, 0)
sl = make([]int, 1, 1)
Recommended
ch = make(chan int, 0)
sl = make([]int, 1, 1)
However, using named constants with channels is not considered an antipattern, for accommodating debugging, math, or platform-specific code.
const c = 0
ch = make(chan int, ch) // No issues raised