RVV-B0012 @ dd8dde6 • go-graphite / carbonapi

Run summary

2 months ago

c2b21bc..dd8dde6

2 mins 12 s

Unused parameter in function RVV-B0012

Bug risk

Minor

23 occurrences in this check

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/timeFunction/function.go

 26	return res
 27}
 28
 29func (f *timeFunction) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) { 30	name, err := e.GetStringArg(0)
 31	if err != nil {
 32		return nil, err

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/timeFunction/function.go

 26	return res
 27}
 28
 29func (f *timeFunction) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) { 30	name, err := e.GetStringArg(0)
 31	if err != nil {
 32		return nil, err

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/sinFunction/function.go

 28}
 29
 30// sinFunction(name, amplitude, step)
 31func (f *sinFunction) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) { 32	name, err := e.GetStringArg(0)
 33	if err != nil {
 34		return nil, err

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/sinFunction/function.go

 28}
 29
 30// sinFunction(name, amplitude, step)
 31func (f *sinFunction) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) { 32	name, err := e.GetStringArg(0)
 33	if err != nil {
 34		return nil, err

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/seriesByTag/function.go

23	return res
24}
25
26func (f *seriesByTag) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {27	var results []*types.MetricData
28	key := parser.MetricRequest{Metric: e.ToString(), From: from, Until: until}
29	data, ok := values[key]

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/randomWalk/function.go

 27}
 28
 29// randomWalk(name, step=60)
 30func (f *randomWalk) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) { 31	name, err := e.GetStringArg(0)
 32	if err != nil {
 33		name = "randomWalk"

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/randomWalk/function.go

 27}
 28
 29// randomWalk(name, step=60)
 30func (f *randomWalk) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) { 31	name, err := e.GetStringArg(0)
 32	if err != nil {
 33		name = "randomWalk"

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/identity/function.go

26}
27
28// identity(name)
29func (f *identity) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {30	name, err := e.GetStringArg(0)
31	if err != nil {
32		return nil, err

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/identity/function.go

26}
27
28// identity(name)
29func (f *identity) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {30	name, err := e.GetStringArg(0)
31	if err != nil {
32		return nil, err

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/graphiteWeb/function.go

323	err    error
324}
325
326func (f *graphiteWeb) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {327	f.logger.Info("received request",
328		zap.Bool("working", f.working),
329	)

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/graphiteWeb/function.go

323	err    error
324}
325
326func (f *graphiteWeb) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {327	f.logger.Info("received request",
328		zap.Bool("working", f.working),
329	)

parameter 'until' seems to be unused, consider removing or renaming it as _

expr/functions/example/function.go

28	return res
29}
30
31func (f *example) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {32	_ = helper.Backref
33	return nil, nil
34}

parameter 'from' seems to be unused, consider removing or renaming it as _

expr/functions/example/function.go

28	return res
29}
30
31func (f *example) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {32	_ = helper.Backref
33	return nil, nil
34}

parameter 'e' seems to be unused, consider removing or renaming it as _

expr/functions/example/function.go

28	return res
29}
30
31func (f *example) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {32	_ = helper.Backref
33	return nil, nil
34}

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/example/function.go

28	return res
29}
30
31func (f *example) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {32	_ = helper.Backref
33	return nil, nil
34}

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/example/function.go

28	return res
29}
30
31func (f *example) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {32	_ = helper.Backref
33	return nil, nil
34}

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/constantLine/function.go

26	return res
27}
28
29func (f *constantLine) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {30	value, err := e.GetFloatArg(0)
31
32	if err != nil {

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/constantLine/function.go

26	return res
27}
28
29func (f *constantLine) Do(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {30	value, err := e.GetFloatArg(0)
31
32	if err != nil {

parameter 'from' seems to be unused, consider removing or renaming it as _

expr/functions/cairo/png/png.go

14
15const HaveGraphSupport = false
16
17func EvalExprGraph(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {18	return nil, nil
19}
20

parameter 'e' seems to be unused, consider removing or renaming it as _

expr/functions/cairo/png/png.go

14
15const HaveGraphSupport = false
16
17func EvalExprGraph(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {18	return nil, nil
19}
20

parameter 'eval' seems to be unused, consider removing or renaming it as _

expr/functions/cairo/png/png.go

14
15const HaveGraphSupport = false
16
17func EvalExprGraph(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {18	return nil, nil
19}
20

parameter 'until' seems to be unused, consider removing or renaming it as _

expr/functions/cairo/png/png.go

14
15const HaveGraphSupport = false
16
17func EvalExprGraph(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {18	return nil, nil
19}
20

parameter 'values' seems to be unused, consider removing or renaming it as _

expr/functions/cairo/png/png.go

14
15const HaveGraphSupport = false
16
17func EvalExprGraph(ctx context.Context, eval interfaces.Evaluator, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {18	return nil, nil
19}
20

Description

Unused parameters in functions or methods should be replaced with _ (underscore) or removed.

Functions or methods with unused parameters can be a symptom of unfinished refactoring or a bug. If an unused parameter is present, it should be named _ (underscore) to avoid raising this issue and better readability.

Bad practice

func abc(unused string) {
    fmt.Println("Not using any passed params.")
}

go-graphite / carbonapi

Bad practice

Recommended